Unhandled exception from EF Framework UpdateUserSessionAsync using SQL Server (BFF v3)

[bamarch]

We are running BFF V3, where CreateUserSessionAsync has the exception handling from DuendeSoftware/products#1797

A similar error to the one that CreateUserSessionAsync handles and suppresses is bubbling up as an unhandled exception for us, coming from UpdateUserSessionAsync - we are using an Azure SQL Server database

Microsoft.Data.SqlClient.SqlException (0x80131904): Cannot insert duplicate key row in object 'BFF.UserSessions' with unique index 'IX_UserSessions_ApplicationName_SessionId'. The duplicate key value is (/app/, 046411AACE84F009C422AE7BFA8D6E6A).
...
   at Microsoft.EntityFrameworkCore.DbContext.SaveChangesAsync(Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at Duende.Bff.EntityFramework.UserSessionStore.UpdateUserSessionAsync(String key, UserSessionUpdate session, CancellationToken cancellationToken) in /_/bff/src/Bff.EntityFramework/Store/UserSessionStore.cs:line 225
   at Duende.Bff.ServerSideTicketStore.RenewAsync(String key, AuthenticationTicket ticket) in /_/bff/src/Bff/SessionManagement/TicketStore/ServerSideTicketStore.cs:line 125
...

Click to expand for full stacktrace

Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while saving the entity changes. See the inner exception for details.
 ---> Microsoft.Data.SqlClient.SqlException (0x80131904): Cannot insert duplicate key row in object 'BFF.UserSessions' with unique index 'IX_UserSessions_ApplicationName_SessionId'. The duplicate key value is (/app/, 046411AACE84F009C422AE7BFA8D6E6A).
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlDataReader.TryHasMoreRows(Boolean& moreRows)
   at Microsoft.Data.SqlClient.SqlDataReader.TryReadInternal(Boolean setTimeout, Boolean& more)
   at Microsoft.Data.SqlClient.SqlDataReader.ReadAsyncExecute(Task task, Object state)
   at Microsoft.Data.SqlClient.SqlDataReader.InvokeAsyncCall[T](SqlDataReaderBaseAsyncCallContext`1 context)
--- End of stack trace from previous location ---
   at Microsoft.EntityFrameworkCore.Update.AffectedCountModificationCommandBatch.ConsumeResultSetWithRowsAffectedOnlyAsync(Int32 commandIndex, RelationalDataReader reader, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.AffectedCountModificationCommandBatch.ConsumeAsync(RelationalDataReader reader, CancellationToken cancellationToken)
ClientConnectionId:36ca7956-2e87-42cf-b301-66c0b3774114
Error Number:2601,State:1,Class:14
ClientConnectionId before routing:a0f4cacd-fcea-4cf2-b778-df6a93c6c480
Routing Destination:bots-ci-group.database.windows.net\e5adbbd6f847,2322
   --- End of inner exception stack trace ---
   at Microsoft.EntityFrameworkCore.Update.AffectedCountModificationCommandBatch.ConsumeAsync(RelationalDataReader reader, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.ExecuteAsync(IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.ExecuteAsync(IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.SqlServer.Update.Internal.SqlServerModificationCommandBatch.ExecuteAsync(IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.ExecuteAsync(IEnumerable`1 commandBatches, IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.ExecuteAsync(IEnumerable`1 commandBatches, IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.ExecuteAsync(IEnumerable`1 commandBatches, IRelationalConnection connection, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.RelationalDatabase.SaveChangesAsync(IList`1 entries, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChangesAsync(IList`1 entriesToSave, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChangesAsync(StateManager stateManager, Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.ExecuteAsync[TState,TResult](TState state, Func`4 operation, Func`4 verifySucceeded, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.DbContext.SaveChangesAsync(Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.DbContext.SaveChangesAsync(Boolean acceptAllChangesOnSuccess, CancellationToken cancellationToken)
   at Duende.Bff.EntityFramework.UserSessionStore.UpdateUserSessionAsync(String key, UserSessionUpdate session, CancellationToken cancellationToken) in /_/bff/src/Bff.EntityFramework/Store/UserSessionStore.cs:line 225
   at Duende.Bff.ServerSideTicketStore.RenewAsync(String key, AuthenticationTicket ticket) in /_/bff/src/Bff/SessionManagement/TicketStore/ServerSideTicketStore.cs:line 125
   at Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler.HandleSignInAsync(ClaimsPrincipal user, AuthenticationProperties properties)
   at Microsoft.AspNetCore.Authentication.AuthenticationService.SignInAsync(HttpContext context, String scheme, ClaimsPrincipal principal, AuthenticationProperties properties)
   at Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler`1.HandleRequestAsync()
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Bots.Identity.Bff.RequestLoggingMiddleware.Invoke(HttpContext context) in /src/Bots.Identity.Bff/RequestLoggingMiddleware.cs:line 24
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

---

The exception is triggered by a /signin-oidc request, resulting in a 500 for the user trying to sign in

This prevents sign in until they clear their cookies, which resolves the issue

We run a single BFF with multiple frontends when testing, which might contribute to this issue ocurring e.g.

app-test.example.com/....
app-test-1.example.com/...

---

Is the error able to be safely ignored, if exception handling was to be added to UpdateUserSessionAsync similarly to CreateUserSessionAsync?

Or is the fix to upgrade asap to BFF v4 with support for multiple frontends?

Thanks!

(p.s. I posted a similar question last week to DuendeSoftware/products#1763 (comment) however I think because the issue is closed it would go un-noticed, so I'm asking here, hope that's okay - thank you!)

[Erwinvandervalk]

Hi Bamarch,

Thank you for your question. The challenge you're running into is that the Server side session implementation in V3 isn't multi-frontend aware and unfortunately there are no plans to make this multi-frontend aware in V3.

Version 4 will have full support for multi-frontends and as such, the server side session store is also updated to help with this. Note, the current latest preview (preview 2) doesn't yet implement this. We'll have another preview available as soon as possible that will support this.

[bamarch]

Ok thank you, we are planning to upgrade to V4 sometime soon so I'll keep an eye on the releases

All our BFF usage is pre-production for now, production will follow later in the year, so we're happy to stay current with releases as much as possible

[Erwinvandervalk]

Thanks. I'll close this thread for now. Please let me know if you're running into challenges upgrading to V4.