Always call LogManager::channel() when registering logging

spawnia · spawnia · commit 94616b0cddec · 2024-03-06T18:35:13.000+01:00
diff --git a/src/LdapServiceProvider.php b/src/LdapServiceProvider.php
@@ -79,11 +79,9 @@ protected function registerLogging(): void
             return;
         }
 
-        Container::getInstance()->setLogger(
-            ($channel = Config::get('ldap.logging.channel'))
-                ? $logger->channel($channel)
-                : $logger
-        );
+        $channelName = Config::get('ldap.logging.channel');
+        $channel = $logger->channel($channelName);
+        Container::getInstance()->setLogger($channel);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -79,11 +79,9 @@ protected function registerLogging(): void`
`79`	`79`	`return;`
`80`	`80`	`}`
`81`	`81`
`82`		`- Container::getInstance()->setLogger(`
`83`		`- ($channel = Config::get('ldap.logging.channel'))`
`84`		`- ? $logger->channel($channel)`
`85`		`- : $logger`
`86`		`- );`
	`82`	`+ $channelName = Config::get('ldap.logging.channel');`
	`83`	`+ $channel = $logger->channel($channelName);`
	`84`	`+ Container::getInstance()->setLogger($channel);`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`/**`