Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 2, 2017

The example on how to require the plugin includes a reference to a fork of the PHPCompatibility standard which seems out of place.

  1. This plugin is AFAIK not only for that standard (though inspired by the issues it had)
  2. For using the PHPCompatibility standard, the fork is no longer needed as of tomorrow with the release of v 8.0.0 which fixes the Composer related issues.

@Potherca Potherca added this to the v0.4.2 milestone Aug 2, 2017
@frenck
Copy link
Contributor

frenck commented Aug 15, 2017

I do agree on this, nevertheless, I do think we need to provide a complete working example.

I would agree on merging this PR and opening a new one ourselves updating the docs (since there are more things to update).

@frenck frenck self-assigned this Aug 15, 2017
@frenck frenck merged commit 87c4990 into PHPCSStandards:master Aug 15, 2017
@jrfnl jrfnl deleted the feature/minor-readme-fix branch August 15, 2017 14:30
@jrfnl
Copy link
Member Author

jrfnl commented Aug 15, 2017

On that note: maybe it's time to remove the frenck/phpcompatibility fork ? or redirect it to the original repo ?

@frenck
Copy link
Contributor

frenck commented Aug 15, 2017

@jrfnl I've marked the package as abandoned in Packagist last week and suggested the original.

@jrfnl
Copy link
Member Author

jrfnl commented Aug 15, 2017

@frenck Excellent! Thanks ❤️

@frenck
Copy link
Contributor

frenck commented Aug 15, 2017

@jrfnl The most awful thing happened tho... some people actually forked my repository after marking it as abandoned. They just ignore the suggestion.... :S

@jrfnl
Copy link
Member Author

jrfnl commented Aug 15, 2017

The most awful thing happened tho... some people actually forked my repository after marking it as abandoned. They just ignore the suggestion...

That... is their responsibility in the end though. You've done the right thing, and PHPCompatibility (at long last) as well, so if people want to be stupid... well, no cure for that, is there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants