Skip to content

Commit a4ba6e0

Browse files
committed
WIP: First pass at integration test for ViewComponent
* While this integration test can run in a single command, it does not run through the test suite properly via `rake test:view_component` * Committing these changes so that the datadog maintainers can assist, then will rebase & rework the branch for a cleaner commit history
1 parent a971f91 commit a4ba6e0

File tree

7 files changed

+519
-3
lines changed

7 files changed

+519
-3
lines changed

Matrixfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,8 @@
294294
'redis-3' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
295295
},
296296
'view_component' => {
297-
'view_component-min' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
298-
'view_component-3' => '❌ 2.5 / ❌ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
297+
'view_component-2.34.0' => '✅ 2.5 / ✅ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
298+
'view_component-3.23.2' => '❌ 2.5 / ❌ 2.6 / ✅ 2.7 / ✅ 3.0 / ✅ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
299299
'view_component-4' => '❌ 2.5 / ❌ 2.6 / ❌ 2.7 / ❌ 3.0 / ❌ 3.1 / ✅ 3.2 / ✅ 3.3 / ✅ 3.4 / ✅ 3.5 / ✅ jruby',
300300
},
301301
'appsec:active_record' => {

appraisal/ruby-3.4.rb

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@
145145
build_coverage_matrix('dalli', [2])
146146
build_coverage_matrix('karafka', min: '2.3.0')
147147
build_coverage_matrix('devise', min: '3.2.1')
148-
build_coverage_matrix('view_component', (3..4), min: '2.34.0')
149148

150149
appraise 'relational_db' do
151150
# ActiveRecord locked because tests are failing with 7.1, which was attempted as a part of Ruby 3.4 testing in CI.
@@ -226,6 +225,20 @@
226225
end
227226
end
228227

228+
229+
[
230+
'4',
231+
'2.34.0',
232+
'3.23.2',
233+
].each do |v|
234+
appraise "view_component-#{v}" do
235+
gem 'view_component', "~> #{v}"
236+
gem "actionview"
237+
gem "rails"
238+
gem 'pg'
239+
end
240+
end
241+
229242
appraise 'opentelemetry' do
230243
gem 'opentelemetry-sdk', '~> 1.1'
231244
end

gemfiles/ruby_3.4_view_component_2.34.0.gemfile

Lines changed: 48 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/ruby_3.4_view_component_2.34.0.gemfile.lock

Lines changed: 302 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)