Add file size in profiling telemetry & fix unit test

Author: ambushwork

dd-sdk-android-core/api/apiSurface

@@ -293,6 +293,7 @@ interface com.datadog.android.core.internal.persistence.Deserializer<P: Any, R:
 fun java.io.File.canReadSafe(com.datadog.android.api.InternalLogger): Boolean
 fun java.io.File.existsSafe(com.datadog.android.api.InternalLogger): Boolean
 fun java.io.File.listFilesSafe(com.datadog.android.api.InternalLogger, java.io.FilenameFilter): Array<java.io.File>?
+fun java.io.File.lengthSafe(com.datadog.android.api.InternalLogger): Long
 fun java.io.File.readTextSafe(java.nio.charset.Charset = Charsets.UTF_8, com.datadog.android.api.InternalLogger): String?
 fun java.io.File.readBytesSafe(com.datadog.android.api.InternalLogger): ByteArray?
 fun java.io.File.readLinesSafe(java.nio.charset.Charset = Charsets.UTF_8, com.datadog.android.api.InternalLogger): List<String>?

dd-sdk-android-core/api/dd-sdk-android-core.api

@@ -798,6 +798,7 @@ public abstract interface class com/datadog/android/core/internal/persistence/De
 public final class com/datadog/android/core/internal/persistence/file/FileExtKt {
 	public static final fun canReadSafe (Ljava/io/File;Lcom/datadog/android/api/InternalLogger;)Z
 	public static final fun existsSafe (Ljava/io/File;Lcom/datadog/android/api/InternalLogger;)Z
+	public static final fun lengthSafe (Ljava/io/File;Lcom/datadog/android/api/InternalLogger;)J
 	public static final fun listFilesSafe (Ljava/io/File;Lcom/datadog/android/api/InternalLogger;Ljava/io/FilenameFilter;)[Ljava/io/File;
 	public static final fun readBytesSafe (Ljava/io/File;Lcom/datadog/android/api/InternalLogger;)[B
 	public static final fun readLinesSafe (Ljava/io/File;Ljava/nio/charset/Charset;Lcom/datadog/android/api/InternalLogger;)Ljava/util/List;

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/persistence/file/FileExt.kt

@@ -130,7 +130,11 @@ fun File.listFilesSafe(internalLogger: InternalLogger, filter: FilenameFilter):
     }
 }
 
-internal fun File.lengthSafe(internalLogger: InternalLogger): Long {
+/**
+ *  Non-throwing version of [File.length]. If exception happens, 0 is returned.
+ */
+@InternalApi
+fun File.lengthSafe(internalLogger: InternalLogger): Long {
     return safeCall(default = 0L, internalLogger) {
         @Suppress("UnsafeThirdPartyFunctionCall")
         length()

features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/internal/perfetto/PerfettoProfiler.kt

@@ -14,8 +14,10 @@ import androidx.annotation.RequiresApi
 import androidx.core.os.StackSamplingRequestBuilder
 import androidx.core.os.requestProfiling
 import com.datadog.android.api.InternalLogger
+import com.datadog.android.core.internal.persistence.file.lengthSafe
 import com.datadog.android.internal.time.TimeProvider
 import com.datadog.android.profiling.internal.Profiler
+import java.io.File
 import java.util.concurrent.ExecutorService
 import java.util.concurrent.Executors
 import java.util.concurrent.TimeUnit
@@ -114,12 +116,22 @@ internal class PerfettoProfiler(
                     TELEMETRY_KEY_ERROR_CODE to result.errorCode,
                     TELEMETRY_KEY_TAG to PROFILING_TAG_APPLICATION_LAUNCH,
                     TELEMETRY_KEY_ERROR_MESSAGE to result.errorMessage,
-                    TELEMETRY_KEY_DURATION to duration
+                    TELEMETRY_KEY_DURATION to duration,
+                    TELEMETRY_KEY_FILE_SIZE to getFileSize(result.resultFilePath)
                 )
             )
         )
     }
 
+    private fun getFileSize(filePath: String?): Long {
+        return internalLogger?.let { logger ->
+            filePath?.let {
+                val file = File(filePath)
+                file.lengthSafe(logger)
+            }
+        } ?: 0
+    }
+
     companion object {
         private val PROFILING_MAX_DURATION_MS = TimeUnit.MINUTES.toMillis(1).toInt()
         private const val PROFILING_TAG_APPLICATION_LAUNCH = "ApplicationLaunch"
@@ -138,5 +150,6 @@ internal class PerfettoProfiler(
         private const val TELEMETRY_KEY_TAG = "tag"
         private const val TELEMETRY_KEY_ERROR_MESSAGE = "error_message"
         private const val TELEMETRY_KEY_DURATION = "duration"
+        private const val TELEMETRY_KEY_FILE_SIZE = "size_bytes"
     }
 }

features/dd-sdk-android-profiling/src/test/kotlin/com/datadog/android/profiling/internal/PerfettoProfilerTest.kt

@@ -188,7 +188,8 @@ class PerfettoProfilerTest {
                 "error_code" to ProfilingResult.ERROR_FAILED_PROFILING_IN_PROGRESS,
                 "tag" to "ApplicationLaunch",
                 "error_message" to fakeErrorMessage,
-                "duration" to fakeDuration
+                "duration" to fakeDuration,
+                "size_bytes" to 0L,
             )
         )
         verify(mockInternalLogger)

features/dd-sdk-android-profiling/src/test/kotlin/com/datadog/android/profiling/internal/ProfilingStorageTest.kt

@@ -8,7 +8,8 @@ package com.datadog.android.profiling.internal
 
 import android.content.Context
 import android.content.SharedPreferences
-import org.assertj.core.api.Assertions
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.AfterEach
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
@@ -18,7 +19,6 @@ import org.mockito.junit.jupiter.MockitoExtension
 import org.mockito.junit.jupiter.MockitoSettings
 import org.mockito.kotlin.any
 import org.mockito.kotlin.doReturn
-import org.mockito.kotlin.times
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
 import org.mockito.quality.Strictness
@@ -46,7 +46,10 @@ internal class ProfilingStorageTest {
         whenever(mockPrefs.edit()) doReturn mockEditor
         whenever(mockEditor.remove(any())) doReturn mockEditor
         whenever(mockEditor.putBoolean(any(), any())) doReturn mockEditor
+    }
 
+    @AfterEach
+    fun `clean up`() {
         // Reset the singleton
         val storageField = ProfilingStorage::class.java.getDeclaredField("sharedPreferencesStorage")
         storageField.isAccessible = true
@@ -72,7 +75,7 @@ internal class ProfilingStorageTest {
         val isEnabled = ProfilingStorage.isProfilingEnabled(mockContext)
 
         // Then
-        Assertions.assertThat(isEnabled).isTrue()
+        assertThat(isEnabled).isTrue()
     }
 
     @Test
@@ -84,7 +87,7 @@ internal class ProfilingStorageTest {
         val isEnabled = ProfilingStorage.isProfilingEnabled(mockContext)
 
         // Then
-        Assertions.assertThat(isEnabled).isFalse()
+        assertThat(isEnabled).isFalse()
     }
 
     @Test
@@ -112,7 +115,7 @@ internal class ProfilingStorageTest {
         latch.await(5, TimeUnit.SECONDS)
 
         // Then
-        verify(mockContext, times(1)).getSharedPreferences(
+        verify(mockContext).getSharedPreferences(
             DATADOG_PREFERENCES_FILE_NAME,
             Context.MODE_PRIVATE
         )