clang_tidy, and codacy fixes

Author: phlptp

include/CLI/Option.hpp

@@ -690,7 +690,7 @@ class Option : public OptionBase<Option> {
     /// Use `get_name(true)` to get the positional name (replaces `get_pname`)
     std::string get_name(bool positional = false, //<[input] Show the positional name
                          bool all_options = false //<[input] Show every option
-                         ) const {
+    ) const {
 
         if(all_options) {
 
@@ -935,7 +935,7 @@ class Option : public OptionBase<Option> {
                         res = std::move(extra);
                     }
                 } else {
-                    res.push_back(std::string{});
+                    res.emplace_back();
                 }
             } else {
                 res = reduced_results();

include/CLI/TypeTools.hpp

@@ -900,7 +900,7 @@ bool lexical_conversion(const std::vector<std ::string> &strings, T &output) {
             retval = retval && lexical_conversion<typename T::value_type, typename XC::value_type>(temp, output.back());
             temp.clear();
             if(!retval) {
-                return retval;
+                return false;
             }
             icount = 0;
         }

tests/app_helper.hpp

@@ -9,7 +9,7 @@
 #include "gtest/gtest.h"
 #include <iostream>
 
-typedef std::vector<std::string> input_t;
+using input_t= std::vector<std::string>;
 
 struct TApp : public ::testing::Test {
     CLI::App app{"My Test Program"};
@@ -27,7 +27,7 @@ class TempFile {
     std::string _name;
 
   public:
-    explicit TempFile(std::string name) : _name(name) {
+    explicit TempFile(std::string name) : _name(std::move(name)) {
         if(!CLI::NonexistentPath(_name).empty())
             throw std::runtime_error(_name);
     }