fix(Avalonia): remove LibVLC for dependency on ffplay

Author: BrycensRanch

SnapX.Avalonia/SnapX.Avalonia.csproj

@@ -11,15 +11,15 @@
     <AssemblyName>snapx-ui</AssemblyName>
     <AssemblyTitle>SnapX UI</AssemblyTitle>
     <ApplicationIcon>Assets\SnapX_Icon.ico</ApplicationIcon>
-    <InvariantGlobalization>true</InvariantGlobalization>
+    <InvariantGlobalization>false</InvariantGlobalization>
     <!-- Recommended Avalonia trimming settings for Native AOT -->
     <AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
     <BuiltInComInteropSupport>false</BuiltInComInteropSupport>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <TrimMode>full</TrimMode>
     <PublishTrimmed>true</PublishTrimmed>
     <Optimize>true</Optimize>
-    <AvaloniaVersion>11.3.1</AvaloniaVersion>
+    <AvaloniaVersion>11.3.2</AvaloniaVersion>
     <SkiaSharpVersion>3.119.0</SkiaSharpVersion>
     <HarfBuzzSharpVersion>8.3.1.1</HarfBuzzSharpVersion>
     <!-- After investigation, this needs to be an absolute path. It should be set by our build script later down the road. -->
@@ -57,22 +57,17 @@
     <PackageReference Include="HarfBuzzSharp.NativeAssets.Linux" Version="$(HarfBuzzSharpVersion)" />
     <PackageReference Include="HarfBuzzSharp.NativeAssets.macOS" Version="$(HarfBuzzSharpVersion)" />
     <PackageReference Include="HarfBuzzSharp.NativeAssets.Win32" Version="$(HarfBuzzSharpVersion)" />
-    <PackageReference Include="LibVLCSharp.Avalonia" Version="3.9.3" />
     <PackageReference Include="Markdown.Avalonia" Version="11.0.2" />
     <PackageReference Include="SkiaSharp" Version="$(SkiaSharpVersion)" />
     <!-- We prefer the NoDependencies flavor -->
     <PackageReference Include="SkiaSharp.NativeAssets.Linux" Version="$(SkiaSharpVersion)" ExcludeAssets="all" />
     <PackageReference Include="SkiaSharp.NativeAssets.Linux.NoDependencies" Version="$(SkiaSharpVersion)" />
     <PackageReference Include="SkiaSharp.NativeAssets.macOS" Version="$(SkiaSharpVersion)" />
     <PackageReference Include="SkiaSharp.NativeAssets.Win32" Version="$(SkiaSharpVersion)" />
-    <PackageReference Condition="$([MSBuild]::IsOsPlatform('OSX'))" Include="VideoLAN.LibVLC.Mac" Version="3.1.3.1" />
-    <PackageReference Condition="$([MSBuild]::IsOsPlatform('Windows'))" Include="VideoLAN.LibVLC.Windows" Version="3.0.21" />
-    <PackageReference Condition="$([MSBuild]::IsOsPlatform('Windows'))" Include="VideoLAN.LibVLC.Windows.GPL" Version="3.0.21" />
     <ProjectReference Include="..\SnapX.CommonUI\SnapX.CommonUI.csproj" />
   </ItemGroup>
   <ItemGroup>
     <Folder Include="Controls\" />
-    <VlcWindowsX86ExcludeFiles Condition="$([MSBuild]::IsOsPlatform('Windows'))" Include="%2A%2A" />
 
   </ItemGroup>
 </Project>

SnapX.Avalonia/SnapXAvalonia.cs

@@ -1,5 +1,6 @@
-using LibVLCSharp.Shared;
+using System.Diagnostics;
 using SnapX.Core;
+using SnapX.Core.Utils.Extensions;
 
 namespace SnapX.Avalonia;
 
@@ -8,22 +9,35 @@ public class SnapXAvalonia : Core.SnapX
     public override async Task PlaySound(Stream stream)
     {
         DebugHelper.WriteLine($"PlaySound {stream.Length} bytes {stream.Position} {stream.CanSeek} {stream.CanRead}");
-        var vlc = new LibVLC(enableDebugLogs: false);
-        DebugHelper.WriteLine($"VLC Version: {vlc.Version}");
-        var MediaPlayer = new MediaPlayer(vlc);
-        var input = new StreamMediaInput(stream);
-        var mediaOptions = new[] { ":input-title-format=flac" };
-
-        var media = new Media(vlc, input, mediaOptions);
-        media.AddOption(":input-title-format=flac");
-        MediaPlayer.EnableHardwareDecoding = true;
-        MediaPlayer.Play(media);
-        MediaPlayer.Stopped += async (Sender, Args) =>
+        var tempFilePath = Path.GetTempFileName();
+        stream.Seek(0, SeekOrigin.Begin);
+        stream.WriteToFile(tempFilePath);
+        var psi = new ProcessStartInfo
         {
-            await stream.DisposeAsync();
-            media.Dispose();
-            input.Dispose();
-            vlc.Dispose();
+            FileName = "ffplay", // Even on Windows, we expect ffplay to be in the $PATH. https://winstall.app/apps/Gyan.FFmpeg
+            Arguments = $"-nodisp -autoexit -hide_banner -loglevel warning \"{tempFilePath}\"",
+            UseShellExecute = false,
+            RedirectStandardOutput = false,
+            RedirectStandardError = false,
+            CreateNoWindow = true
         };
+
+        try
+        {
+            using var process = Process.Start(psi);
+            if (process is not null) await process.WaitForExitAsync();
+        }
+        finally
+        {
+            try
+            {
+                File.Delete(tempFilePath);
+            }
+            catch
+            {
+                /* ignore */
+            }
+        }
+
     }
 }