Skip to content

Conversation

@JoshLozensky
Copy link
Contributor

@JoshLozensky JoshLozensky commented Feb 19, 2025

For testing, will be working with Bogdan/Travis on E2E testing as this isn't really approachable via unit tests.

Since MSAL made AcquireTokenForClient.WithFmiPath() available, in the one place we use the AcquireTokenForClient method, adding a check for and insertion of the FMI Path so Id Web customers can make use of this new functionality. Addresses issue #3240

@JoshLozensky JoshLozensky requested a review from a team as a code owner February 19, 2025 00:18
@JoshLozensky JoshLozensky marked this pull request as draft February 19, 2025 00:20
@github-actions
Copy link

Summary

Summary
Generated on: 2/19/2025 - 12:35:43 AM
Coverage date: 2/19/2025 - 12:34:58 AM - 2/19/2025 - 12:35:40 AM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions
Copy link

Summary

Summary
Generated on: 2/19/2025 - 1:22:48 AM
Coverage date: 2/19/2025 - 1:22:01 AM - 2/19/2025 - 1:22:45 AM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start

@JoshLozensky JoshLozensky marked this pull request as ready for review February 19, 2025 21:13
@github-actions
Copy link

Summary

Summary
Generated on: 2/19/2025 - 9:33:22 PM
Coverage date: 2/19/2025 - 9:32:36 PM - 2/19/2025 - 9:33:20 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks, @JoshLozensky

cc: @bgavrilMS

@JoshLozensky JoshLozensky merged commit ae4211e into master Feb 20, 2025
8 checks passed
@JoshLozensky JoshLozensky deleted the lozensky/AddFmiPath branch February 20, 2025 01:34
@pmaytak pmaytak modified the milestones: 3.8.1, 3.8.0 Mar 21, 2025
This was referenced Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants