Skip to content

Conversation

@christinalau0
Copy link
Contributor

Reason for Change:

  • Update golang from v1.20 to v1.23
    • No vendor folder changes
    • Update golang dev image to 1.23.2-bullseye
  • Update golangci-lint to v1.61.0 to support golang v1.23
    • Fixed new lint errors
    • Disabled revive linter as it threw hundreds of unused parameter errors. This can be fixed in a later PR.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0
Copy link
Contributor Author

Verified successful run with Azure E2E PR pipeline.

Copy link
Contributor

@JesusAlvarezTorres JesusAlvarezTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christinalau0 christinalau0 merged commit c3f4c11 into Azure:master Oct 24, 2024
2 checks passed
@christinalau0 christinalau0 deleted the go-1.23 branch October 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants