Skip to content

Commit 0f27a2e

Browse files
committed
refactor: Improve types.
1 parent 82214a1 commit 0f27a2e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/BetterEmbed.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ import {MessageEmbed, MessageEmbedOptions} from 'discord.js';
33
type AnyObject = {[k: string]: any};
44

55
type Template = MessageEmbedOptions;
6-
76
type Templates = { [k in string | 'basic' | 'color' | 'complete' | 'image']: Template }
87

8+
type CheckSizeKey = keyof Template | string;
9+
type CheckSizeContent = Template[keyof Template];
10+
911
export const templates: Templates = {
1012
basic: {
1113
footer: {
@@ -90,14 +92,12 @@ export class BetterEmbed extends MessageEmbed {
9092

9193
public checkSize(field: 'fields'): {index: number, limit: number} & ({name: boolean} | {value: boolean}) | boolean
9294
public checkSize(field: keyof Template): boolean;
93-
public checkSize(): {[k in keyof Template | string]: {content: string | Template[keyof Template], limit: number}}
95+
public checkSize(): { [k in CheckSizeKey]: {content: CheckSizeContent, limit: number} }
9496
public checkSize(field?: keyof Template) {
9597
if (!field) {
96-
type key = keyof Template | string;
97-
type content = string | Template[keyof Template]
98-
const fields: {[k in key]: {content: content, limit: number}} = {};
98+
const fields: { [k in CheckSizeKey]: {content: CheckSizeContent, limit: number} } = {};
9999

100-
function addField(name: key, content: content, limit: number) {
100+
function addField(name: CheckSizeKey, content: CheckSizeContent, limit: number) {
101101
fields[name] = {
102102
content,
103103
limit,
@@ -127,14 +127,14 @@ export class BetterEmbed extends MessageEmbed {
127127
return {
128128
index,
129129
name: true,
130-
limit: limits.fields.name
131-
}
130+
limit: limits.fields.name,
131+
};
132132
} else if (field.value.length > limits.fields.value) {
133133
return {
134134
index,
135135
value: true,
136-
limit: limits.fields.value
137-
}
136+
limit: limits.fields.value,
137+
};
138138
}
139139
}
140140
return false;

0 commit comments

Comments
 (0)