Skip to content

Conversation

@praveenCY
Copy link
Contributor

Summary of changes

Fix for UART init and deinit in cypress kits using UnbufferedSerial enable_input/enable_output functions.

Problem: Calling below sequence for UnbufferedSerial causes UART logs to be stopped.

  1. pc.enable_input(false);
  2. pc.enable_output(false);
  3. pc.enable_input(true);
  4. pc.enable_output(true);

Reason: serial_free is called during step 2 and serial_init called during step 3 doesnot really call Cypress uart init function due to be stdio_uart_inited check.

Solution: Clear stdio_uart_inited during serial_free so that serial init will properly call cyhal_uart_init

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/team-cypress


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 14, 2021
@ciarmcom ciarmcom requested a review from a team April 14, 2021 03:30
@ciarmcom
Copy link
Member

@praveenCY, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 14, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 14, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f4f8d8f into ARMmbed:master Apr 14, 2021
@mergify mergify bot removed the ready for merge label Apr 14, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants