Skip to content

LPC1768: Fix ARM toolchain baremetal by defining 2 memory region #12369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

LPC1768: Fix ARM toolchain baremetal by defining 2 memory region #12369

merged 1 commit into from
Feb 5, 2020

Conversation

@hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Feb 5, 2020 •
edited
Loading

Summary of changes

Define 2 memory region model for LPC1768 to fix #12360
The changes are based on the scatter file in TOOLCHAIN_ARM_MICRO

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @evedon @rajkan01 @adbridge @kjbracey-arm

@hugueskamba
LPC1768: Fix ARM toolchain baremetal by defining 2 memory region
193e49c 
The changes are based on the scatter file in TOOLCHAIN_ARM_MICRO
@ciarmcom ciarmcom requested review from a team, adbridge and maclobdell February 5, 2020 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 5, 2020

@hugueskamba, thank you for your changes.
@maclobdell @adbridge @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing nightly 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 5, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Feb 5, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 5, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

CI finally has all build PASSED 💯

@0xc0170 0xc0170 merged commit b140fd0 into ARMmbed:master Feb 5, 2020
@mergify mergify bot removed the ready for merge label Feb 5, 2020
@hugueskamba hugueskamba deleted the hk-fixlpc1768-baremetal branch February 5, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mprse mprse Awaiting requested review from mprse

@kjbracey kjbracey Awaiting requested review from kjbracey

@evedon evedon Awaiting requested review from evedon

@rajkan01 rajkan01 Awaiting requested review from rajkan01

@adbridge adbridge Awaiting requested review from adbridge

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees

No one assigned

Labels

release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PR #12225 broke ARMCC for LPC1768 - heap symbol not defined

4 participants

@hugueskamba @ciarmcom @0xc0170 @mbed-ci