Skip to content

Commit c1f15a4

Browse files
committed
Add comments for excluded example projects and re-store function signature code style
Also ensure the verbose option uses -vv as is in the master branch
1 parent 621449e commit c1f15a4

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

tools/test/examples/examples_lib.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -359,15 +359,7 @@ def status(message):
359359
return results
360360

361361

362-
def compile_repos(
363-
config,
364-
toolchains,
365-
targets,
366-
profiles,
367-
verbose,
368-
examples,
369-
post_checks,
370-
):
362+
def compile_repos(config, toolchains, targets, profiles, verbose, examples, post_checks):
371363
"""Compiles combinations of example programs, targets and compile chains.
372364
373365
The results are returned in a [key: value] dictionary format:
@@ -417,7 +409,7 @@ def compile_repos(
417409
valid_choices(example['toolchains'], toolchains),
418410
example['features']):
419411

420-
build_command = ["mbed-cli", "compile", "-t", toolchain, "-m", target] + (['-v'] if verbose else [])
412+
build_command = ["mbed-cli", "compile", "-t", toolchain, "-m", target] + (['-vv'] if verbose else [])
421413
if profiles:
422414
for profile in profiles:
423415
build_command.extend(["--profile", profile])
@@ -605,10 +597,10 @@ def _post_build_check_floating_point(example_name, elf_file):
605597
)
606598
)
607599

608-
600+
# Specify the example project that should not be checked for floating point because they will always fail
609601
POST_BUILD_CHECK_FLOATS_EXCLUDED_EXAMPLES = [
610-
"mbed-os-example-lorawan",
611-
"nanostack-border-router",
602+
"mbed-os-example-lorawan", # The LoRaWAN is not actively worked on and we are consideing dropping LoRaWAN example from Mbed OS examples.
603+
"nanostack-border-router", # nanostack-border-router example depends on ST changes to stm-spirit1-rf-driver library.
612604
]
613605
POST_BUILD_CHECK_FLOATS = "FLOATS"
614606
SUPPORTED_POST_BUILD_CHECKS = {

0 commit comments

Comments
 (0)