Response to comments

Author: multiplemonomials

tools/cmake/app.cmake

@@ -66,4 +66,4 @@ include(${CMAKE_CURRENT_LIST_DIR}/create_distro.cmake)
 
 # load upload method
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/upload_methods)
-include(${CMAKE_CURRENT_LIST_DIR}/UploadMethodManager.cmake)
+include(${CMAKE_CURRENT_LIST_DIR}/UploadMethodManager.cmake)

tools/cmake/upload_methods/FindOpenOCD.cmake

@@ -12,7 +12,7 @@
 
 set(OpenOCD_PATHS "")
 
-# try to figure out where JLink may be installed.
+# try to figure out where OpenOCD may be installed.
 if("${CMAKE_HOST_SYSTEM_NAME}" STREQUAL "Windows")
 
     # on Windows, assume that the user extracted the binaries to Program Files

tools/cmake/upload_methods/UploadMethodJLINK.cmake

@@ -58,4 +58,4 @@ add_custom_target(gdbserver
 	-LocalhostOnly
 	-noIR
 	-port ${GDB_PORT}
-	USES_TERMINAL)
+	USES_TERMINAL)

tools/cmake/upload_methods/UploadMethodMBED.cmake

@@ -32,4 +32,4 @@ function(gen_upload_target TARGET_NAME BIN_FILE)
 
 	add_dependencies(flash-${TARGET_NAME} ${TARGET_NAME})
 
-endfunction(gen_upload_target)
+endfunction(gen_upload_target)

tools/cmake/upload_methods/UploadMethodNONE.cmake

@@ -13,4 +13,4 @@ function(gen_upload_target TARGET_NAME BIN_FILE)
 
 	# do nothing
 
-endfunction(gen_upload_target)
+endfunction(gen_upload_target)

tools/cmake/upload_methods/UploadMethodOPENOCD.cmake

@@ -31,4 +31,4 @@ add_custom_target(gdbserver
 	${OpenOCD}
 	${OPENOCD_CHIP_CONFIG_COMMANDS}
 	-c "gdb_port ${GDB_PORT}"
-	USES_TERMINAL)
+	USES_TERMINAL)

tools/cmake/upload_methods/UploadMethodPYOCD.cmake

@@ -55,4 +55,4 @@ add_custom_target(gdbserver
 	-p ${GDB_PORT}
 	--persist
 	--semihosting
-	USES_TERMINAL)
+	USES_TERMINAL)

tools/cmake/upload_methods/UploadMethodSTM32CUBE.cmake

@@ -58,4 +58,4 @@ add_custom_target(gdbserver
 	--persistent # don't close debugger after GDB disconnects, matches behavior of other tools like J-Link
 	-p ${GDB_PORT}
 	${STM32CUBE_GDB_PROBE_ARGS}
-	USES_TERMINAL)
+	USES_TERMINAL)

tools/cmake/upload_methods/install_bin_file.py

@@ -41,7 +41,7 @@ def error(lines, code=-1):
 
 if len(sys.argv) < 3:
     print("Error: Usage: python " + sys.argv[0] + " <path to bin file> <Mbed OS target name> <serial baudrate for sending break> [Target UID for distinguishing multiple targets]")
-    exit(1)
+    sys.exit(1)
 
 bin_file = sys.argv[1]
 target_name = sys.argv[2]