Fully enforce NonCopyable

Make NonCopyable fully operational so it gives compile errors in all
build profiles.

Author: kjbracey

UNITTESTS/features/netsocket/TCPServer/test_TCPServer.cpp

@@ -54,7 +54,7 @@ TEST_F(TestTCPServer, constructor)
 
 TEST_F(TestTCPServer, constructor_parameters)
 {
-    TCPServer serverParam = TCPServer(dynamic_cast<NetworkStack *>(&stack));
+    TCPServer serverParam(dynamic_cast<NetworkStack *>(&stack));
     const SocketAddress a("127.0.0.1", 1024);
     EXPECT_EQ(serverParam.connect(a), NSAPI_ERROR_OK);
 }

UNITTESTS/features/netsocket/TCPSocket/test_TCPSocket.cpp

@@ -62,7 +62,7 @@ TEST_F(TestTCPSocket, constructor)
 
 TEST_F(TestTCPSocket, constructor_parameters)
 {
-    TCPSocket socketParam = TCPSocket();
+    TCPSocket socketParam;
     socketParam.open(dynamic_cast<NetworkStack *>(&stack));
     const SocketAddress a("127.0.0.1", 1024);
     EXPECT_EQ(socketParam.connect(a), NSAPI_ERROR_OK);

platform/NonCopyable.h

@@ -17,11 +17,6 @@
 #ifndef MBED_NONCOPYABLE_H_
 #define MBED_NONCOPYABLE_H_
 
-#if (!defined(MBED_DEBUG) && (MBED_CONF_PLATFORM_FORCE_NON_COPYABLE_ERROR == 0))
-#include "platform/mbed_toolchain.h"
-#include "platform/mbed_debug.h"
-#endif
-
 namespace mbed {
 
 /** \addtogroup platform-public-api */
@@ -178,39 +173,6 @@ class NonCopyable {
      */
     ~NonCopyable() = default;
 
-#if (!defined(MBED_DEBUG) && (MBED_CONF_PLATFORM_FORCE_NON_COPYABLE_ERROR == 0))
-    /**
-     * NonCopyable copy constructor.
-     *
-     * A compile time warning is issued when this function is used, and a runtime
-     * warning is printed when the copy construction of the noncopyable happens.
-     *
-     * If you see this warning, your code is probably doing something unspecified.
-     * Copying of noncopyable resources can lead to resource leak and random error.
-     */
-    MBED_DEPRECATED("Invalid copy construction of a NonCopyable resource.")
-    NonCopyable(const NonCopyable &)
-    {
-        debug("Invalid copy construction of a NonCopyable resource: %s\r\n", MBED_PRETTY_FUNCTION);
-    }
-
-    /**
-     * NonCopyable copy assignment operator.
-     *
-     * A compile time warning is issued when this function is used, and a runtime
-     * warning is printed when the copy construction of the noncopyable happens.
-     *
-     * If you see this warning, your code is probably doing something unspecified.
-     * Copying of noncopyable resources can lead to resource leak and random error.
-     */
-    MBED_DEPRECATED("Invalid copy assignment of a NonCopyable resource.")
-    NonCopyable &operator=(const NonCopyable &)
-    {
-        debug("Invalid copy assignment of a NonCopyable resource: %s\r\n", MBED_PRETTY_FUNCTION);
-        return *this;
-    }
-
-#else
 private:
     /**
      * Declare copy constructor as private. Any attempt to copy construct
@@ -224,7 +186,6 @@ class NonCopyable {
      */
     NonCopyable &operator=(const NonCopyable &);
 #endif
-#endif
 };
 
 /**@}*/

platform/mbed_lib.json

@@ -37,8 +37,8 @@
         },
 
         "force-non-copyable-error": {
-            "help": "Force compile time error when a NonCopyable object is copied",
-            "value": false
+            "help": "Force compile time error when a NonCopyable object is copied (obsolete option - always treated as true)",
+            "value": true
         },
 
         "poll-use-lowpower-timer": {