event handler should not affect internal state

paul-szczepanek-arm · paul-szczepanek-arm · commit 108177065f87 · 2020-09-17T17:21:37.000+01:00
diff --git a/connectivity/FEATURE_BLE/source/generic/GapImpl.cpp b/connectivity/FEATURE_BLE/source/generic/GapImpl.cpp
@@ -2238,13 +2238,14 @@ void Gap::on_enhanced_connection_complete(
     clock_accuracy_t master_clock_accuracy
 )
 {
+    if (own_role == connection_role_t::CENTRAL) {
+        _initiating = false;
+    }
+
     if (!_event_handler) {
         return;
     }
 
-    if (own_role == connection_role_t::CENTRAL) {
-        _initiating = false;
-    }
 
     _event_handler->onConnectionComplete(
         ConnectionCompleteEvent(

Original file line number	Diff line number	Diff line change
`@@ -2238,13 +2238,14 @@ void Gap::on_enhanced_connection_complete(`
`2238`	`2238`	`clock_accuracy_t master_clock_accuracy`
`2239`	`2239`	`)`
`2240`	`2240`	`{`
	`2241`	`+ if (own_role == connection_role_t::CENTRAL) {`
	`2242`	`+ _initiating = false;`
	`2243`	`+ }`
	`2244`	`+`
`2241`	`2245`	`if (!_event_handler) {`
`2242`	`2246`	`return;`
`2243`	`2247`	`}`
`2244`	`2248`
`2245`		`- if (own_role == connection_role_t::CENTRAL) {`
`2246`		`- _initiating = false;`
`2247`		`- }`
`2248`	`2249`
`2249`	`2250`	`_event_handler->onConnectionComplete(`
`2250`	`2251`	`ConnectionCompleteEvent(`