Skip to content

Conversation

@adbridge
Copy link
Contributor

Also show how to use non_periodic periods and cancel() function.

@adbridge adbridge requested review from 0xc0170 and evedon January 12, 2021 16:48
Also show how to use non_periodic and cancel.
@adbridge
Copy link
Contributor Author

Ah this depends on : ARMmbed/mbed-os#14087 being merged first

Copy link

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. I would add the expected output for greater clarity.

// ^
// Events 1,2,4
// dispatched
//
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. Could you also show the expected output and perhaps print the time in handler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's a good idea

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like ascii art to show the sequence. I remember we did it in minar scheduler and it was quite clear what when should be triggered.

event_thread.join();
}

}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at end of file missing

@adbridge
Copy link
Contributor Author

@evedon PR updated, please re-review

@adbridge adbridge requested review from donatieng and removed request for donatieng January 19, 2021 17:19
// ^
// Events 1,2,4
// dispatched
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like ascii art to show the sequence. I remember we did it in minar scheduler and it was quite clear what when should be triggered.

@adbridge
Copy link
Contributor Author

@0xc0170 I think you can just merge this now then :) ?

@0xc0170 0xc0170 merged commit a377eba into ARMmbed:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants