-
Notifications
You must be signed in to change notification settings - Fork 26
Update Events example to use Chrono times #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also show how to use non_periodic and cancel.
|
Ah this depends on : ARMmbed/mbed-os#14087 being merged first |
evedon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition. I would add the expected output for greater clarity.
| // ^ | ||
| // Events 1,2,4 | ||
| // dispatched | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great. Could you also show the expected output and perhaps print the time in handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like ascii art to show the sequence. I remember we did it in minar scheduler and it was quite clear what when should be triggered.
APIs_RTOS/Events_ex_1/main.cpp
Outdated
| event_thread.join(); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline at end of file missing
|
@evedon PR updated, please re-review |
| // ^ | ||
| // Events 1,2,4 | ||
| // dispatched | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like ascii art to show the sequence. I remember we did it in minar scheduler and it was quite clear what when should be triggered.
|
@0xc0170 I think you can just merge this now then :) ? |
Also show how to use non_periodic periods and cancel() function.